[ENH] Add assessment tool categorization workflow #574

surchs · 2023-10-17T00:18:16Z

Closes #566
Closes #567

Changes proposed in this pull request:

new component components/category-toolgroup.vue that handles assessment tool groups
dropdown element to select from CognitiveAtlas terms to create a new assessment tool
table that contains all created assessment tools that can be clicked to select a given tool (unselect not possible)
table that contains all columns that have been assigned as "about" assessment tool. Clicking a column with an assessment tool selected maps this column to the tool
logic to prevent the next page to be accessible unless all assessment-columns have been mapped to something
elements in the new component are not visible on the DOM until at least one column is mapped to assessment tool
corresponding store state, mutations and getters
bunch of tests

Checklist

PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
PR links to GitHub issue with mention Closes #XXXX
Tests pass
Checks pass

For new features:

Tests have been added

For bug fixes:

There is at least one test that would fail under the original bug conditions.

and test

updated the component test

Co-authored-by: Arman Jahanpour <[email protected]>

also reflected visually

But only display the label

Not yet in store

netlify · 2023-10-17T00:18:21Z

✅ Deploy Preview for neurobagel-annotator ready!

Name	Link
🔨 Latest commit	`3783ed2`
🔍 Latest deploy log	https://app.netlify.com/sites/neurobagel-annotator/deploys/65380fed5649ac00085d6f0d
😎 Deploy Preview	https://deploy-preview-574--neurobagel-annotator.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

We need a mutation for when a column is linked to a tool

Looks like we did remove the dupliacted getter after all?

@input

Clicking the little 'x' icon in vue-select also fires the @input hook but has a payload of null, which breaks the processing method

No tests yet

So I can debug my component better

also: props work now

But I don't understand what It enables reactivity though So it's good

rmanaem

Thanks for the PR @surchs!
🍒 I left a few comments for changes and considerations.
Regarding the new e2e test, what are your thoughts on treating it as the app e2e test to replace the simple-e2etest? Or integrating the new e2e test into existing ones to test the new functionalities added. On its own it seems out of place.

store/index.js

cypress/unit/store-getter-isPageAccessible.cy.js

cypress/unit/store-mutation-createToolGroup.cy.js

store/index.js

cypress/component/category-toolgroup.cy.js

rmanaem

The changes look good and ready to merge once the component tests pass 🧑‍🍳

cypress/component/category-toolgroup.cy.js

rmanaem and others added 15 commits October 12, 2023 15:32

Added lintfix script to package.json

1df0468

Added assessment column table

0a37a10

and test

Added tool group dropdown and assessment tool table

8fb4cd3

updated the component test

Prevent duplicate tools from being created

7e54fcb

Updated test

55aafd8

Added functionality for highlighting selected tool

4a71e4a

Co-authored-by: Arman Jahanpour <[email protected]>

don't need clicks

cb22d7f

Added capability to map column to tool

17a7367

also reflected visually

Basic layout

bd91e5b

First attempt at getting tool list from store

9c01367

Pass id with tool

0d74fed

But only display the label

Pass tool by identifier

8f7ec5f

WIP: fire mutation for createTool

98f9c79

Not yet in store

Toolgroup component can handle state and store

8e22338

Added store mutation for creating tools

8113dd5

surchs added 14 commits October 16, 2023 20:23

Add columnToToolMap in the store

410d9cb

WIP: adding failing test as reminder

29dc8d0

We need a mutation for when a column is linked to a tool

Add mutation for mapping column to tool

f4b41a2

Implement column to tool mapping mutation

391868b

Add simplistic initialization of column2Tool Map

fcc9f83

Refactored store functions and tests

7bd666d

Refactor unit tests to follow updated store column getter

ea0dbc8

Looks like we did remove the dupliacted getter after all?

[FIX] column no longer styled if selectedTool is null

d3ebcf8

[FIX] deselecting dropdown no longer crashes app

715f0dc

Clicking the little 'x' icon in vue-select also fires the @input hook but has a payload of null, which breaks the processing method

Add the toolgroup workflow to the categorization page

aeef78f

Add test to protect against null-crash

d87e193

[ENH] Prevent page from advancing if not all columns mapped

dcf8cab

No tests yet

Merge branch 'master' into feat-566

9722f13

[ENH] no elements render unless one column selected

5e245d2

[FIX] adjust nextPage unit test to new logic

610e899

surchs marked this pull request as ready for review October 18, 2023 00:39

surchs added 11 commits October 19, 2023 14:29

Adding a simple page test I can understand

61abe3a

So I can debug my component better

Provide a super silly tool component

4bf950e

First basic store integration

7650527

[WIP] we're not yet passing props correctly

81f3bdf

Add getter for columns mapped to tools

42fc3ba

Parseing unique values for tool columns

457a87c

Single annot component + test

e161615

also: props work now

Tool missing value button exists

2717700

single tool component emits missing value event

f4a8116

Parent tool component fires mutation when child emits

502ed0d

Adding this here does something

3c88725

But I don't understand what It enables reactivity though So it's good

rmanaem self-requested a review October 20, 2023 19:14

rmanaem requested changes Oct 20, 2023

View reviewed changes

surchs added 4 commits October 24, 2023 09:59

Apply first round of review suggestions

cd4f8f1

Second round of review edits

76356fb

Refactor tool group mutation name

37538f2

Make the component use good props

578832c

rmanaem approved these changes Oct 24, 2023

View reviewed changes

rmanaem reviewed Oct 24, 2023

View reviewed changes

cypress/component/category-toolgroup.cy.js Outdated Show resolved Hide resolved

surchs and others added 2 commits October 24, 2023 14:35

Complete the refactor

c606474

Merge branch 'master' into feat-566

3783ed2

surchs merged commit c5990af into master Oct 24, 2023
7 checks passed

surchs deleted the feat-566 branch October 24, 2023 18:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENH] Add assessment tool categorization workflow #574

[ENH] Add assessment tool categorization workflow #574

surchs commented Oct 17, 2023 •

edited by rmanaem

Loading

netlify bot commented Oct 17, 2023 •

edited

Loading

rmanaem left a comment •

edited

Loading

rmanaem left a comment •

edited

Loading

[ENH] Add assessment tool categorization workflow #574

[ENH] Add assessment tool categorization workflow #574

Conversation

surchs commented Oct 17, 2023 • edited by rmanaem Loading

Checklist

netlify bot commented Oct 17, 2023 • edited Loading

✅ Deploy Preview for neurobagel-annotator ready!

rmanaem left a comment • edited Loading

Choose a reason for hiding this comment

rmanaem left a comment • edited Loading

Choose a reason for hiding this comment

surchs commented Oct 17, 2023 •

edited by rmanaem

Loading

netlify bot commented Oct 17, 2023 •

edited

Loading

rmanaem left a comment •

edited

Loading

rmanaem left a comment •

edited

Loading